Upgrade alertmanager v0.32.1#7462
Open
SungJin1212 wants to merge 3 commits intocortexproject:masterfrom
Open
Conversation
b6cfba4 to
be25a00
Compare
Member
Author
|
We need a CI to inject an alertmanager ui assets to the vendor automatically. |
4cfedc0 to
5718eca
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
c2d455a to
d7f014f
Compare
SungJin1212
commented
May 4, 2026
| router := route.New().WithPrefix(am.cfg.ExternalURL.Path) | ||
|
|
||
| ui.Register(router, webReload, util_log.GoKitLogToSlog(log.With(am.logger, "component", "ui"))) | ||
| ui.Register(router) |
Member
Author
There was a problem hiding this comment.
We maintain our alertmanager ui (github.com/cortexproject/cortex/pkg/alertmanager/ui) whenever we update the alertmanager.
friedrichg
approved these changes
May 4, 2026
friedrichg
reviewed
May 4, 2026
| golang.org/x/sync v0.20.0 | ||
| golang.org/x/time v0.14.0 | ||
| google.golang.org/grpc v1.79.3 | ||
| google.golang.org/grpc v1.80.0 |
Member
There was a problem hiding this comment.
it's a performance improvement for cortex, let's try it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the Prometheus alertmanager version to v0.32.1
How to add alertmanager ui assets since v0.32.1
Key Alertmanager Changes
Protobuf Migration
clusterpb.FullStatemigrated fromproxy.fjygbaifeng.eu.org/gogo/protobuftogoogle.golang.org/protobufUI Embed
Alertmanager UI assets
(app/dist/)are now embedded via//go:embedapp/dist in ui/web.go. Thedist/entry in.gitignoremust explicitly allow vendored UI assets via!vendor/**/dist/.Silence API Model Restructure
The swagger-generated API models now split
Silenceinto separate types:*string,*strfmt.DateTime)createdByfield is now required when creating a silence via the HTTP APIMatchersuseopen_api_models.Matchers ([]*Matcher)instead ofamlabels.MatchersSilenceStateActive/Expired→SilenceStatusStateActive/SilenceStatusStateExpiredWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags