test: improve FetchAdapter binding regression tests#1138
Merged
Conversation
…ness Replace 3 weak tests from PR #1130 (hand-written replica, regex-extracted new Function() eval, standalone wrong-precedence demo) with 2 behavioral tests that compile and run the actual generated FetchAdapter in a node:vm sandbox. The remaining regex test is kept as a static source-text guard. The new tests exercise both branches of the generated constructor expression `(fetchFn ?? createFetch()).bind(globalThis)` through the real generated class, catching regressions that string-matching alone misses (e.g. the precedence bug `fetchFn ?? createFetch().bind(globalThis)`). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NorOldBurden
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchAdapterclass at runtimeProblem with the previous tests
PR #1130 added 4 tests for the
.bind(globalThis)fix (PR #1128), but 3 of them had gaps:TestFetchAdapterhand-written replicanew Function()regex extractionVerified empirically: the precedence bug variant
fetchFn ?? createFetch().bind(globalThis)passed all 3 tests green (afterjest -uto update snapshots).New approach
loadGeneratedFetchAdapter()helper:generateOrmClientFile()to get the real template outputts.transpileModule()to CommonJSnode:vmsandbox with stubbed imports (createFetch,./realtime)FetchAdapterconstructorTwo behavioral tests cover both
??branches:createFetch()result must be bound toglobalThisVerification
Full suite: 20 suites, 347 tests, 123 snapshots — all green, 0 regressions.
Test plan
pnpm testingraphql/codegen— 347 tests passpnpm buildacross full monorepo — all packages compile🤖 Generated with Claude Code