Skip to content

feat(presigned-url): enforce bulk upload limits (maxBulkFiles + maxBulkTotalSize) #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
May 8, 2026
Merged

feat(presigned-url): enforce bulk upload limits (maxBulkFiles + maxBulkTotalSize) #1081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion graphile/graphile-presigned-url-plugin/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,25 @@ export function createPresignedUrlPlugin(
);
if (!bucket) throw new Error('BUCKET_NOT_FOUND');

// Enforce bulk upload limits
const filesArray = vals.files as any[];
if (filesArray.length > storageConfig.maxBulkFiles) {
throw new Error(
`BULK_UPLOAD_FILES_EXCEEDED: ${filesArray.length} files exceeds maximum of ${storageConfig.maxBulkFiles} per batch`,
);
}
const totalSize = filesArray.reduce((sum: number, f: any) => sum + (f.size || 0), 0);
if (totalSize > storageConfig.maxBulkTotalSize) {
throw new Error(
`BULK_UPLOAD_SIZE_EXCEEDED: ${totalSize} bytes exceeds maximum of ${storageConfig.maxBulkTotalSize} bytes per batch`,
);
}

const s3ForDb = resolveS3ForDatabase(options, storageConfig, databaseId);
await ensureS3BucketExists(options, s3ForDb.bucket, bucket, databaseId, storageConfig.allowedOrigins);

const results = [];
for (const file of vals.files) {
for (const file of filesArray) {
results.push(
await processSingleFile(options, txClient, storageConfig, databaseId, bucket, s3ForDb, {
contentHash: file.contentHash,
Expand Down
Loading