Feat/export metaschema#17
Open
Zetazzz wants to merge 6 commits into
Open
Conversation
pyramation
reviewed
Mar 3, 2026
|
|
||
| // Discover database_id and name from metaschema | ||
| const dbsResult = await pgPool.query( | ||
| 'SELECT id, name FROM metaschema_public.database' |
pyramation
reviewed
Mar 3, 2026
| } | ||
|
|
||
| const targetRow = params.databaseName | ||
| ? dbsResult.rows.find((r: any) => r.name === params.databaseName) |
Contributor
There was a problem hiding this comment.
do this in the above SQL ^^^^
pyramation
reviewed
Mar 3, 2026
|
|
||
| // Check that sql_actions exist for this database before exporting | ||
| const actionsResult = await pgPool.query( | ||
| 'SELECT count(*)::int AS cnt FROM db_migrate.sql_actions WHERE database_id = $1', |
Contributor
There was a problem hiding this comment.
why do you need to do this? shouldn't we just call export and not touch sql?
Contributor
There was a problem hiding this comment.
maybe I'm misunderstanding
1752f5c to
e278bb9
Compare
09d945f to
d97698d
Compare
Contributor
|
Heads-up: repository history was rewritten on 2026-05-12 to scrub leaked secrets (Postgres/pgAdmin default passwords, an AWS access key ID, generated This PR shows "DIRTY" / merge-conflict status because git fetch --all --prune
git checkout <this-branch>
git reset --hard origin/<this-branch> # your local branch tip moved too — pick up the rewritten version
git rebase origin/main # rebase onto rewritten main
# resolve conflicts (usually trivial — mostly secret-placeholder + the 4 deleted interweb-*.yaml files)
git push --force-with-leaseOr merge instead of rebase if the branch is shared with others: git merge origin/main
git pushNotes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.