Skip to content

ci: drop unused CS_ZEROKMS_HOST and CS_CTS_HOST overrides#402

Merged
coderdan merged 1 commit intomainfrom
dan/ci-drop-unused-host-overrides
May 4, 2026
Merged

ci: drop unused CS_ZEROKMS_HOST and CS_CTS_HOST overrides#402
coderdan merged 1 commit intomainfrom
dan/ci-drop-unused-host-overrides

Conversation

@coderdan
Copy link
Copy Markdown
Contributor

@coderdan coderdan commented May 4, 2026

Summary

  • The protect SDK derives the CTS host from the workspace CRN and the ZeroKMS host from the services claims in the CTS-issued JWT, so the CS_ZEROKMS_HOST / CS_CTS_HOST lines we were echoing into the four package .env files in CI were never consulted at runtime.
  • Remove them from the protect, stack, protect-dynamodb, and drizzle .env-creation steps. (Two of the four blocks also had a copy-paste typo writing the values into ./packages/protect/.env; deleting them moots that as well.)

Same change is already on PR #393's branch and CI passed there with the dependabot secrets; landing it on main first ensures the standard Actions env stays green before we merge that PR.

Test plan

  • CI "Test JS" workflow passes on this PR

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to optimize environment variable handling during test setup.

The protect SDK derives the CTS host from the workspace CRN and the
ZeroKMS host from the services claims in the CTS-issued JWT, so these
env vars are not consulted at runtime. Remove them from all four
.env-creation steps.
@coderdan coderdan requested a review from a team as a code owner May 4, 2026 03:52
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

⚠️ No Changeset found

Latest commit: f715851

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

📝 Walkthrough

Walkthrough

Removes CS_ZEROKMS_HOST and CS_CTS_HOST environment variable writes from .env file creation steps for four packages in the test workflow, consolidating variable definition to the e2e-tests job's job-level env.

Changes

Environment Variable Consolidation

Layer / File(s) Summary
Workflow Configuration
.github/workflows/tests.yml
Removes echo commands that appended CS_ZEROKMS_HOST and CS_CTS_HOST to .env files in ./packages/protect/, ./packages/stack/, ./packages/protect-dynamodb/, and ./packages/drizzle/ during the install job's setup steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit tidies workflow lines,
Where env vars once crossed all signs.
Now consolidated, clean and bright,
The CI pipeline runs just right! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely describes the main change: removing unused environment variable overrides from CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dan/ci-drop-unused-host-overrides

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@coderdan coderdan merged commit 6e54b8d into main May 4, 2026
7 checks passed
@coderdan coderdan deleted the dan/ci-drop-unused-host-overrides branch May 4, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants