ci: drop unused CS_ZEROKMS_HOST and CS_CTS_HOST overrides#402
Conversation
The protect SDK derives the CTS host from the workspace CRN and the ZeroKMS host from the services claims in the CTS-issued JWT, so these env vars are not consulted at runtime. Remove them from all four .env-creation steps.
|
📝 WalkthroughWalkthroughRemoves ChangesEnvironment Variable Consolidation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
CS_ZEROKMS_HOST/CS_CTS_HOSTlines we were echoing into the four package.envfiles in CI were never consulted at runtime..env-creation steps. (Two of the four blocks also had a copy-paste typo writing the values into./packages/protect/.env; deleting them moots that as well.)Same change is already on PR #393's branch and CI passed there with the dependabot secrets; landing it on
mainfirst ensures the standard Actions env stays green before we merge that PR.Test plan
Summary by CodeRabbit