Skip to content

Add oxlint to the repo#102

Open
marcalexiei wants to merge 11 commits intochangesets:masterfrom
marcalexiei:oxlint
Open

Add oxlint to the repo#102
marcalexiei wants to merge 11 commits intochangesets:masterfrom
marcalexiei:oxlint

Conversation

@marcalexiei
Copy link
Copy Markdown
Contributor


Alongside adding oxlint I also updated typescript to the latest version

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel.

A member of the Team first needs to authorize it.

Comment on lines +4 to +9
"categories": {
"correctness": "error",
"suspicious": "error",
"perf": "error",
"pedantic": "error"
},
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t enabled the style and restrictions categories yet to keep the review scope lighter.

Let me know if you’d like me to include them.
I can either add them in this PR or follow up with a separate one, whichever you prefer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what style would bring to the table over just relying on the formatter.

As to restrictions, I briefly looked through the list and some of those rules seem to be useful while some doesn't so perhaps we should try to enable that and turn off specific rules we don't like. I'll try to make a pass through this to assess which ones we want.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what style would bring to the table over just relying on the formatter.

Actually I find some of the style rules, like typescript/consistent-type-imports, pretty useful.
I would consider give some of them a go, but we we can do it later


As to restrictions, I briefly looked through the list and some of those rules seem to be useful while some doesn't so perhaps we should try to enable that and turn off specific rules we don't like. I'll try to make a pass through this to assess which ones we want.

Sure, I'll focus on addressing your other feedbacks for now.

@marcalexiei marcalexiei marked this pull request as ready for review April 2, 2026 06:36
@marcalexiei marcalexiei requested a review from emmatown as a code owner April 2, 2026 06:36
This was referenced Apr 2, 2026
@marcalexiei marcalexiei requested a review from Andarist April 3, 2026 12:09
@marcalexiei
Copy link
Copy Markdown
Contributor Author

Thanks for the thought review!
I should have addressed all the feedback, let me know if you need additional changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants