Update helm template for deprecated APIs

[rikatz]

This changes the Helm Chart templates to remove deprecated APIs and use the stable ones.

[rikatz]

/assign @munnerz

[james-w]

Hi, thanks for the contribution.

When were those stable APIs added?

This is just an example so we don't have to worry about compatibility too much, but it's good to be compatible with
the versions that most people are going to be running in the wild.

Thanks,

James

[james-w]

Looking at 1.14:

It has

• apiregistration.k8s.io/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#apiservice-v1-apiregistration-k8s-io
• apps/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#apps-v1
• rbac.authorization.k8s.io/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#rolebinding-v1-rbac-authorization-k8s-io

The others are the cert-manager.io APIs, where we can reasonably assume that people are up to date, so

/lgtm

Thanks!

[munnerz]

/approve

…

On Wed, 15 Jul 2020 at 09:03, James Westby ***@***.***> wrote: Looking at 1.14: It has - apiregistration.k8s.io/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#apiservice-v1-apiregistration-k8s-io - apps/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#apps-v1 - rbac.authorization.k8s.io/v1: https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/#rolebinding-v1-rbac-authorization-k8s-io The others are the cert-manager.io APIs, where we can reasonably assume that people are up to date, so /lgtm Thanks! — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRWP4ZETLQS5B2LJTSRHLR3VPDRANCNFSM4ODBGR3Q> .

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: munnerz, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment