Skip to content

Move repo for cert-manager-webhook-example#440

Merged
jetstack-bot merged 2 commits into
cert-manager:masterfrom
jakexks:move-cert-manager-webhook-example
Feb 23, 2021
Merged

Move repo for cert-manager-webhook-example#440
jetstack-bot merged 2 commits into
cert-manager:masterfrom
jakexks:move-cert-manager-webhook-example

Conversation

@jakexks
Copy link
Copy Markdown
Member

@jakexks jakexks commented Feb 23, 2021

@jakexks
Move repo for cert-manager-webhook-example
43ea264 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Feb 23, 2021

@jakexks: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2021
@jetstack-bot jetstack-bot added the area/cert-manager Indicates a PR related to cert-manager label Feb 23, 2021
@jakexks jakexks removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 23, 2021
@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2021
@JoshVanL
Copy link
Copy Markdown
Contributor

JoshVanL commented Feb 23, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@JoshVanL
Copy link
Copy Markdown
Contributor

JoshVanL commented Feb 23, 2021

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@jakexks
Move cert-manager-webhook-example under the cert-manager folder
ca7f6c7 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@jakexks
Copy link
Copy Markdown
Member Author

jakexks commented Feb 23, 2021

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@jakexks jakexks requested review from JoshVanL and munnerz February 23, 2021 17:52
@JoshVanL
Copy link
Copy Markdown
Contributor

JoshVanL commented Feb 23, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Feb 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, simplyzee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@jetstack-bot jetstack-bot merged commit 365f052 into cert-manager:master Feb 23, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Feb 23, 2021

@jakexks: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-webhook-example-presubmits.yaml using file ``
    • key cert-manager-webhook-example-presubmits.yaml using file config/jobs/cert-manager/webhook-example/cert-manager-webhook-example-presubmits.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
Details

In response to this:

For context: cert-manager/webhook-example#23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakexks jakexks deleted the move-cert-manager-webhook-example branch February 24, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maelvls maelvls Awaiting requested review from maelvls

@munnerz munnerz Awaiting requested review from munnerz

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

1 more reviewer

@simplyzee simplyzee simplyzee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoshVanL JoshVanL

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jakexks @jetstack-bot @JoshVanL @munnerz @simplyzee