Merged
Conversation
lbartoli79
force-pushed
the
firefox_parser_fix
branch
from
fc91727 to
cfe07aa
Compare
lbartoli79
commented
Aug 6, 2024
| socket = match.groupdict().get('socket') | ||
| status = match.groupdict().get('status') | ||
| if status == '804b0007': | ||
| if status in ['804b0007', '4b0007']: |
Contributor
Author
There was a problem hiding this comment.
Added this based on nsresult::NS_NET_STATUS_CONNECTING_TO
claud-io
approved these changes
Aug 6, 2024
pmeenan
approved these changes
Aug 7, 2024
Contributor
pmeenan
left a comment
pmeenan
left a comment
There was a problem hiding this comment.
LGTM. I assume it is intended, but the OCSP pref change will be a behavior change and the OCSP time for non-stapled origins will be hidden after the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Firefox log parser and add support for latest selenium:
Before:
After:
