Merged
Conversation
FedericoMulas
suggested changes
Sep 27, 2023
Contributor
Author
|
Thanks. Added |
Contributor
Author
|
@mjkozicki could you merge when you get a chance (I'm not authorized for the agent - which I'm good with keeping that way) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the rfc5424 logging to only be imported when that mode of logging is being used and also adds an (optional) requirement for the
tzlocalmodule which is required by the rfc5424 logging code.This way the agents that are already deployed should install the module if it's not already on the systems.
Without these changes, the agents are likely to stop working as soon as they update unless tzlocal is installed on them (not part of the default install script).