Map netlog priorities to the Dev Tools equivalents#431
Merged
tkadlec merged 1 commit intocatchpoint:masterfrom Sep 14, 2021
Merged
Map netlog priorities to the Dev Tools equivalents#431tkadlec merged 1 commit intocatchpoint:masterfrom
tkadlec merged 1 commit intocatchpoint:masterfrom
Conversation
Contributor
|
Ooo...yeah, I like this a lot. That was always one of those things that seemed like an arbitrary difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the reported Priorities to use the same names as Dev Tools uses for the different priority levels. I am in the process of moving Blink to also use the dev tools names so hopefully we can have one set of priority names that we use when talking about Chrome prioritization (netlog internally will still use the net names because it is locked into the API but I will change the priorities doc to de-emphasize the net names).
With this, both Dev Tools and WPT will show the same names for priorities which should make it a lot easier to talk about, particularly as Priority Hints are going to be coming along soon.
I'll have a PR shortly to also map the names in the UI for older tests so they are displayed consistently.