Skip to content

Map netlog priorities to the Dev Tools equivalents#431

Merged
tkadlec merged 1 commit intocatchpoint:masterfrom
pmeenan:priorities
Sep 14, 2021
Merged

Map netlog priorities to the Dev Tools equivalents#431
tkadlec merged 1 commit intocatchpoint:masterfrom
pmeenan:priorities

Conversation

@pmeenan
Copy link
Copy Markdown
Contributor

@pmeenan pmeenan commented Sep 14, 2021

This changes the reported Priorities to use the same names as Dev Tools uses for the different priority levels. I am in the process of moving Blink to also use the dev tools names so hopefully we can have one set of priority names that we use when talking about Chrome prioritization (netlog internally will still use the net names because it is locked into the API but I will change the priorities doc to de-emphasize the net names).

With this, both Dev Tools and WPT will show the same names for priorities which should make it a lot easier to talk about, particularly as Priority Hints are going to be coming along soon.

I'll have a PR shortly to also map the names in the UI for older tests so they are displayed consistently.

@tkadlec
Copy link
Copy Markdown
Contributor

tkadlec commented Sep 14, 2021

Ooo...yeah, I like this a lot. That was always one of those things that seemed like an arbitrary difference.

@tkadlec tkadlec merged commit 6273513 into catchpoint:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants