Change concat to << since the buffer no longer supports the former#652
Merged
Conversation
Collaborator
Author
|
Woohoo! Green tests! |
lcreid
approved these changes
Jul 24, 2022
Contributor
lcreid
left a comment
lcreid
left a comment
There was a problem hiding this comment.
Thanks for fixing this. I suspect the test started to fail with rails/rails#45614, which is a PR that speeds up template processing noticeably. Re-reading the documentation, it looks like the use of concat was never really encouraged anyway, so it's not surprising that this usage isn't really considered to be something that needs to be supported.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.