Skip to content

deps(gazelle): Bump WORKSPACE gazelle version 0.36.0 --> 0.47.0 (to match MODULE.bazel)#3717

Merged
dougthor42 merged 2 commits intobazel-contrib:mainfrom
dougthor42:workspace-gazelle-version
Apr 19, 2026
Merged

deps(gazelle): Bump WORKSPACE gazelle version 0.36.0 --> 0.47.0 (to match MODULE.bazel)#3717
dougthor42 merged 2 commits intobazel-contrib:mainfrom
dougthor42:workspace-gazelle-version

Conversation

@dougthor42
Copy link
Copy Markdown
Collaborator

Note that this implicitly updates go from 1.21.13 to 1.22.9

Steps taken to generate this commit:

  1. Manually update go.mod
  2. go mod tidy
  3. bazel run //:gazelle_update_repos

Note that this implicitly updates go from 1.21.13 to 1.22.9

Steps taken to generate this commit:

1.  Manually update go.mod
2.  `go mod tidy`
3.  bazel run //:gazelle_update_repos
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the bazel-gazelle dependency to 0.47.0 and updates the Go version to 1.22.9. It also removes numerous unused go_repository entries from gazelle/deps.bzl and updates buildtools and doublestar. Feedback was provided regarding the toolchain directive in go.mod, which specifies Go 1.24.13 and contradicts the intended Go 1.22.9 version, potentially causing compatibility issues for users.

Comment thread gazelle/go.mod
Comment on lines +4 to +5

toolchain go1.24.13
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The toolchain directive specifies go1.24.13, which is inconsistent with the PR description and the go directive (both indicating a bump to 1.22.9). If the project intends to support Go 1.22.9 as the minimum version, this directive should be removed. Including a newer toolchain version here will force users to have Go 1.24+ installed or downloaded, which may not be desired if the project aims for Go 1.22 compatibility.

@dougthor42 dougthor42 added this pull request to the merge queue Apr 19, 2026
Merged via the queue into bazel-contrib:main with commit fe43548 Apr 19, 2026
4 checks passed
@dougthor42 dougthor42 deleted the workspace-gazelle-version branch April 19, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants