feat(interfaces): overhaul IPolicyRegistry and resync IB20/IB20Security#13
Closed
ilikesymmetry wants to merge 1 commit into
Closed
feat(interfaces): overhaul IPolicyRegistry and resync IB20/IB20Security#13ilikesymmetry wants to merge 1 commit into
ilikesymmetry wants to merge 1 commit into
Conversation
IPolicyRegistry: - Rename WHITELIST→ALLOWLIST, BLACKLIST→BLOCKLIST; remove COMPOUND type - Drop compound-related structs, errors, events, and functions - Collapse isAuthorizedSender/Recipient/MintRecipient into single isAuthorized - Replace policyData() with separate policyAdmin() and policyType() views - modifyPolicy* now accept address[] for batch updates - Rename policyIdCounter→nextPolicyId, setPolicyAdmin→updatePolicyAdmin, modifyPolicyWhitelist/Blacklist→updatePolicyAllowlist/Blocklist IB20: - Remove redeem surface (redeem, redeemWithMemo, minimumRedeemable, setMinimumRedeemable, Redeemed, MinimumRedeemableUpdated, MinimumRedeemableNotMet) — moved to IB20Security - Update policy model natspec to drop compound-slot and redeem language IB20Security: - Add security-specific redeemPolicyId + updateRedeemPolicy - Host full redeem surface with redeemPolicyId-gated natspec - Relocate Redeemed, MinimumRedeemableUpdated events and MinimumRedeemableNotMet error here from IB20 - Fix RedeemPolicyUpdated event comment (was "updateMintPolicy") - Rewrite inherited-surface @dev block to document redeem separately DESIGN_NOTES: propagate all terminology and design changes Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAuthorizedSender/Recipient/MintRecipientin favor of singleisAuthorized; replacepolicyData()withpolicyAdmin()+policyType(); batchupdatePolicyAllowlist/Blocklistacceptaddress[]; renamepolicyIdCounter→nextPolicyId,setPolicyAdmin→updatePolicyAdminredeemPolicyId+updateRedeemPolicy; host full redeem surface gated byredeemPolicyId; relocateRedeemed,MinimumRedeemableUpdated,MinimumRedeemableNotMethere from IB20; fixRedeemPolicyUpdatedevent comment; rewrite inherited-surface@devblockTest plan
forge buildcompiles cleanlyWHITELIST,BLACKLIST,COMPOUND,isAuthorizedSender,isAuthorizedRecipient,isAuthorizedMintRecipient,policyData,policyIdCounter🤖 Generated with Claude Code