feat: Added Auth tab support by pmathew92 · Pull Request #962 · auth0/Auth0.Android

pmathew92 · 2026-04-29T10:59:40Z

Changes

This PT adds support for Android Auth TabIntent to the WebAuthentication login and logout flow.

References

https://developer.android.com/reference/androidx/browser/auth/AuthTabIntent

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not

Checklist

I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors

…roid into auth_tab_support

utkrishtsahu · 2026-04-30T07:21:50Z

+    @Suppress("DEPRECATION")
    public override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
+        super.onActivityResult(requestCode, resultCode, data)
+        // If the Activity Result API (e.g. auth tab) already handled this result and called


remove this generated comment

This is added intentionally to highlight why this if check is needed

utkrishtsahu · 2026-04-30T07:22:05Z


    override fun onResume() {
        super.onResume()
+        // Auth Tab results are delivered via the Activity Result API callback (onAuthTabResult)


remove this generated comment

This is added intentionally to highlight why this if check is needed

utkrishtsahu · 2026-04-30T07:24:02Z

+        customTabsClientMock = Mockito.mockStatic(CustomTabsClient.class);
+        customTabsClientMock.when(() -> CustomTabsClient.isAuthTabSupported(eq(context), any(String.class))).thenReturn(true);
+
+        CustomTabsOptions ctOptions = CustomTabsOptions.newBuilder()


missing .withAuthTab() — test never enters the auth tab code path, passes for the wrong reason

Good catch. Fixed

the test now has .withAuthTab() but still uses the default BrowserPicker (no mock returning a package). This means preferredPackage will be null, so the method falls back at the first guard (preferredPackage == null) — not at the scheme check it's supposed to test. The test still passes for the wrong reason, just at a different fallback point.

utkrishtsahu · 2026-04-30T07:26:48Z

-        @ExperimentalAuth0Api
-        @NonNull
-        public Builder withEphemeralBrowsing() {
+        Builder withEphemeralBrowsing() {


visibility reduced from public to package-private without callout; this is a breaking API change

No.. this is inside the CustomTabsOptions class. Not the public API

utkrishtsahu · 2026-04-30T07:28:48Z

 import com.google.androidbrowserhelper.trusted.TwaLauncher

-public open class AuthenticationActivity : Activity() {
+public open class AuthenticationActivity : ComponentActivity() {


ComponentActivity() — base class change from Activity is public API-breaking for subclassers;
Can we document in V4 migration guide

this is within the SDK. Not for public APIs. It is open for testing purpose. Do you see scenario where this can fail for users updating to V4 ?

since this targets v4 and subclassing AuthenticationActivity isn't a documented use case, this is fine. No action needed.

utkrishtsahu · 2026-04-30T07:30:09Z

+        }
    private var customTabsController: CustomTabsController? = null
-    override fun onNewIntent(intent: Intent?) {
+    override fun onNewIntent(intent: Intent) {


signature changed from nullable to non-null; subclass overrides of the old signature will break

Again an internal implementation. No effect for consuming clients

utkrishtsahu · 2026-04-30T08:40:30Z

                            null,
                            TwaLauncher.CCT_FALLBACK_STRATEGY
                    );
+                } else if (customTabsOptions.isAuthTab()) {


else if (customTabsOptions.isAuthTab()) — TWA silently takes priority over Auth Tab; consider logging a warning or documenting this precedence

Added comments and document to highlight this

utkrishtsahu · 2026-04-30T08:41:32Z

-public open class AuthenticationActivity : Activity() {
+public open class AuthenticationActivity : ComponentActivity() {
    private var intentLaunched = false
+    internal val authTabResultHandler = AuthTabResultHandler(


internal val authTabResultHandler — internal exposes to entire module, not just tests; consider private + @VisibleForTesting(PRIVATE)

We intentionally chose internal over private + @VisibleForTesting as part of the collaborator pattern

AuthTabResultHandler is internal itself, so the combination is module-scoped regardless

The collaborator pattern was specifically chosen to avoid @VisibleForTesting on the activity — adding it back would contradict the design

Tests in the same module access it cleanly without annotation

utkrishtsahu · 2026-04-30T08:42:59Z

+            return;
+        }
+
+        bindService();


bindService() called before scheme null-check at line 198; if scheme is null, this work is wasted before falling back to launchAsDefault which calls bindService again

Good point. Moved scheme check above bindService()

utkrishtsahu · 2026-04-30T10:25:06Z

+        customTabsClientMock = Mockito.mockStatic(CustomTabsClient.class);
+        customTabsClientMock.when(() -> CustomTabsClient.isAuthTabSupported(eq(context), any(String.class))).thenReturn(true);
+
+        CustomTabsOptions ctOptions = CustomTabsOptions.newBuilder()


the test now has .withAuthTab() but still uses the default BrowserPicker (no mock returning a package). This means preferredPackage will be null, so the method falls back at the first guard (preferredPackage == null) — not at the scheme check it's supposed to test. The test still passes for the wrong reason, just at a different fallback point.

…are not present

pmathew92 added 8 commits April 29, 2026 15:03

feat: Added support for Auth Tab for web authentication flow

8e512b1

Removed redundant methods from CustomTabsOptions class

85d15a1

feat: Added support for Auth Tab for web authentication flow

061d1d6

Removed redundant methods from CustomTabsOptions class

454245e

Merge branch 'auth_tab_support' of https://github.com/auth0/Auth0.And…

54e35b3

…roid into auth_tab_support

Added guard for super onActivityResult scenario

3f0f26c

added example for auth tab usage

a36e71e

Updated doc for Auth tab limitations

f6959ca

pmathew92 marked this pull request as ready for review April 30, 2026 06:58

pmathew92 requested a review from a team as a code owner April 30, 2026 06:58

utkrishtsahu reviewed Apr 30, 2026

View reviewed changes

fixed missing authTab in a test

126c244

utkrishtsahu reviewed Apr 30, 2026

View reviewed changes

utkrishtsahu requested changes Apr 30, 2026

View reviewed changes

Addressed review comments

b1747b7

utkrishtsahu requested changes Apr 30, 2026

View reviewed changes

Made the Authtab controller throw error when redirect uri and scheme …

7211065

…are not present

Conversation

pmathew92 commented Apr 29, 2026

Changes

References

Testing

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants