Atom 1.32 breaks syntax highlighting

[hermidalc]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Python syntax highlighting is not working after update to Atom 1.32

Steps to Reproduce

1. Open any .py file in Atom 1.32

Expected behavior: Proper syntax highlighting

Actual behavior: Parts of code which should be highlighted are now broken and are white

Reproduces how often: 100%

Versions

Atom 1.32

[winstliu]

Thanks for contributing! Can you please share some pictures or other describe in further detail the differences in syntax highlighting that you are experiencing?

[mskornilov]

It seems like the new Tree-sitter parsing system is causing this weird behaviour.
Turning it off in the settings did the trick for me.
Here's a screenshot with Tree-sitter on:

And here's with it off:

[hermidalc]

Thanks @mskornilov for posting pics of the changed syntax highlighting behavior. Mine looks the same.

[hermidalc]

Sorry now that I think about it, which syntax highlighting style (1.32 w/ tree-sitter or 1.31.2 without) is the correct one? Maybe it was broken all this time and now is fixed in 1.32?

[mskornilov]

I'd say the old one is correct, at least it properly detects arguments, class methods etc.
tree-sitter:

without:

[yousseftarek]

This also extends to JavaScript syntax highlighting. I'm having the same issue here as well.

[TheElementalOfDestruction]

• # TODO is nolonger being highlighted in pink/purple. Now it is just grey.
  

• Don't know if this one was intentional, but typing '.whatever' makes 'whatever' appear as white, and '.' appear as orange.
  

• Triple quotes ( ''' or """ ) do not start highlighting until a close triple quote appears if the first one is not the first character on the line. Instead, they turn everything white after them. They also mess up some of the highlighting before them as well. So if they appear after a space or tab, they do this.
  

• Quotes sometimes just completely crap themselves and stop suddenly after non-letter characters if no end-quote is found
  

[TheElementalOfDestruction]

Brackets in strings are no longer highlighted orange

Edit: I suppose I should have mentioned this was being caused by the tree-sitter change. Turning off tree sitter fixes this.

[hermidalc]

It's definitely the Tree Sitter Parsers that causing the syntax highlighting problem, and in multiple languages. In Atom 1.32 if you go to Settings -> Core -> Tree Sitter Parsers and uncheck it highlighting behavior returns to normal. I'm actually kind of surprised something like this wasn't caught by someone before 1.32 rolled out.

[Ben3eeE]

@TheElementalOfCreation

TODO is no longer being highlighted in pink/purple. Now it is just grey.
Brackets in strings are no longer highlighted orange

This is tracked in atom/language-todo#82 & atom/atom#18196