Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Support new reaction emoji #1916

@smashwilson

Description

@smashwilson

Prerequisites

Description

GitHub.com shipped additional reaction emoji. We should support rendering these in our pull request detail item.

Steps to Reproduce

  1. Open a pull request detail open on a pull request or issue that includes a 🚀 or 👀 reaction emoji.

Expected behavior:

The 🚀 and 👀 emoji should appear like the others do.

Actual behavior:

existing-behavior

Reproduces how often:

100%

Versions

atom/github 0.24.0

Additional Information

Here's the source code we need to add additional members to:

const reactionTypeToEmoji = {
THUMBS_UP: '👍',
THUMBS_DOWN: '👎',
LAUGH: '😆',
HOORAY: '🎉',
CONFUSED: '😕',
HEART: '❤️',
};

While we're in there, we should ensure we gracefully skip unrecognized emoji.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issuepapercutSmall-scope issues and bugs we can use to backfill our sprint plans

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions