GH-3507: Reduce allocation overhead of no-op GeospatialStatistics.Builder#3508
Open
arouel wants to merge 1 commit intoapache:masterfrom
Open
GH-3507: Reduce allocation overhead of no-op GeospatialStatistics.Builder#3508arouel wants to merge 1 commit intoapache:masterfrom
GeospatialStatistics.Builder#3508arouel wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GeospatialStatistics.noopBuilder()is called for every non-geometry column in every row group. Each call allocates a newNoopBuilderalong with aWKBReader,BoundingBox, andGeospatialTypesthat are never used. Each subsequentbuild()allocates a newGeospatialStatistics(null, null)that is equally throwaway. On wide schemas with many columns, this creates unnecessary GC pressure on the write path.What changes are included in this PR?
NoopBuildera singleton via a staticINSTANCEfield returned bynoopBuilder()build()result as a staticEMPTYinstance, since it is stateless (null fields, with merge/abort guarded by null checks)Builder(boolean)constructor that skips field initialization so the singleton does not allocate unusedWKBReader,BoundingBox, andGeospatialTypesobjectsWKBReaderinitialization from the field declaration into the publicBuilder()constructor, so only real builders pay the costAre these changes tested?
Yes. Two new tests were added to
TestGeospatialStatistics:testNoopBuilderIsSingleton: verifiesnoopBuilder()returns the same builder instance andbuild()returns the same cached resulttestNoopBuilderUpdateAndAbortAreNoOps: exercisesupdate(nonNull),update(null), andabort()on the noop builder to confirm none throw, and asserts the built result remains invalid with null fieldsAre there any user-facing changes?
No. This is an internal optimization with no API or behavioral changes.
Closes #3507