GH-3501: Speed up DictionaryValuesWriter.shouldFallBack()#3502
Open
arouel wants to merge 1 commit intoapache:masterfrom
Open
GH-3501: Speed up DictionaryValuesWriter.shouldFallBack()#3502arouel wants to merge 1 commit intoapache:masterfrom
DictionaryValuesWriter.shouldFallBack()#3502arouel wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DictionaryValuesWriter.shouldFallBack()is called byFallbackValuesWriter.checkFallback()after every single value write. The current implementation dispatches a virtual call togetDictionarySize()on every invocation, even for duplicate values that do not grow the dictionary. BothdictionaryByteSizeand the dictionary entry count can only increase when a new entry is added (inside theif (id == -1)branch), so the size-exceeded condition can only transition from false to true at that exact point. The per-write virtual dispatch is redundant work for the common case.What changes are included in this PR?
Single file change to DictionaryValuesWriter.java:
dictionarySizeExceededfield, reset inresetDictionary().checkDictionarySizeLimit(int newDictionarySize)method that sets the flag whendictionaryByteSize > maxDictionaryByteSize || newDictionarySize > MAX_DICTIONARY_ENTRIES.checkDictionarySizeLimit(id + 1)after inserting a new dictionary entry.shouldFallBack()becomes returndictionarySizeExceeded, a simple field read with no virtual dispatch.Are these changes tested?
Yes. All existing tests in
TestDictionarypass without modification, confirming semantic equivalence. The new testtestCheckDictionarySizeLimitExceedsByEntryCountdirectly exercises the previously untestedMAX_DICTIONARY_ENTRIESboundary incheckDictionarySizeLimit, verifying correct trigger and reset behavior.Are there any user-facing changes?
No. This is an internal optimization with no API, behavior, or configuration changes.
Closes #3501