Avoid injection issues in the JDBC datasource (backport #2654)#2673
Open
jbonofre wants to merge 1 commit into
Open
Avoid injection issues in the JDBC datasource (backport #2654)#2673jbonofre wants to merge 1 commit into
jbonofre wants to merge 1 commit into
Conversation
(cherry picked from commit 6a86e6f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2654 to
karaf-4.4.x.There is a minor security issue in the JDBC datasource - the datasource name parameter is concatenated directly into OSGi LDAP-syntax filter strings without escaping.
For example:
Now
jdbc:ds-info *returns information on "test". Andjdbc:ds-delete *deletes all tables.Cherry-picked from 6a86e6f (authored by @coheigea).
Note: PR #2654 is still open against
main; this backport is being raised in parallel at the maintainer's request.