KAFKA-20368: Use LinkedHashMap for deterministic metric tags order in RLMExpirationTask

[cychiu8]

Summary: use MetricsUtils.getTags to handle metricTags in RLMExpirationTask.

[Copilot]

Pull request overview

This PR makes RemoteLogManager’s per-partition retention metrics produce deterministic JMX MBean tag ordering by constructing the tag map via MetricsUtils.getTags (which preserves insertion order), and updates tests to match the new stable tag order and validate metric cleanup on task cancellation.

Changes:

• Switch RLMExpirationTask metric tag creation to MetricsUtils.getTags(...) for deterministic tag iteration order.
• Update JMX metric name expectations in RemoteLogManagerTest to match the stable topic,partition order.
• Extend the task-cancellation metrics test to assert the metrics are actually deregistered from the Yammer registry.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java	Uses MetricsUtils.getTags to build ordered metricTags for retention gauges in RLMExpirationTask.
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java	Adjusts expected JMX suffix ordering for retention metrics and adds assertions that cancellation deregisters them.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cychiu8]

the JMX metric of kafka.log.remote:type=RemoteLogManager
before change: (partition → topic)

after change: (topic → partition)

[nileshkumar3]

LGTM. Using deterministic tag ordering here makes sense, and the JMX metric name assertions are updated consistently with the new tag order.