Skip to content

[2.4.x] Add ap_*_timingsafe#639

Open
notroj wants to merge 3 commits intoapache:2.4.xfrom
notroj:24x-ap_star_timingsafe
Open

[2.4.x] Add ap_*_timingsafe#639
notroj wants to merge 3 commits intoapache:2.4.xfrom
notroj:24x-ap_star_timingsafe

Conversation

@notroj
Copy link
Copy Markdown
Collaborator

@notroj notroj commented Apr 27, 2026

Merge r1933389 from trunk:

Add ap_*_timingsafe() constant-time comparison functions:

* include/httpd.h: Declare ap_memeq_timingsafe(), ap_streq_timingsafe(), ap_strneq_timingsafe().

* server/util.c: Implement, wrapping apr_*_timingsafe() if APR >= 1.8, with a fallback to copied-in versions.

* modules/aaa/mod_auth_digest.c: Replace apr_crypto_equals() with ap_memeq_timingsafe(). Remove apr_crypto.h include.

* modules/session/mod_session_crypto.c: Replace local ap_crypto_equals() with ap_memeq_timingsafe(). Remove the local implementation and macro alias.

* include/ap_mmn.h: Bump MMN minor.

(cherry picked from commit 7f5de0aebf5c04796aa9c25153413b09d609763b)

notroj and others added 3 commits April 27, 2026 13:58
Add ap_*_timingsafe() constant-time comparison functions:

* include/httpd.h: Declare ap_memeq_timingsafe(),
  ap_streq_timingsafe(), ap_strneq_timingsafe().

* server/util.c: Implement, wrapping apr_*_timingsafe() if
  APR >= 1.8, with a fallback to copied-in versions.

* modules/aaa/mod_auth_digest.c: Replace apr_crypto_equals()
  with ap_memeq_timingsafe(). Remove apr_crypto.h include.

* modules/session/mod_session_crypto.c: Replace local
  ap_crypto_equals() with ap_memeq_timingsafe(). Remove
  the local implementation and macro alias.

* include/ap_mmn.h: Bump MMN minor.

(cherry picked from commit 7f5de0a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant