[rust][writer] Add DynamicWriteBatchSizeEstimator#532
Merged
fresh-borzoni merged 3 commits intoapache:mainfrom May 10, 2026
Merged
[rust][writer] Add DynamicWriteBatchSizeEstimator#532fresh-borzoni merged 3 commits intoapache:mainfrom
fresh-borzoni merged 3 commits intoapache:mainfrom
Conversation
Member
Author
Contributor
charlesdong1991
left a comment
charlesdong1991
left a comment
There was a problem hiding this comment.
Nice PR!! i left some thoughts! @fresh-borzoni PTAL 🙏
fresh-borzoni
force-pushed
the
feat/dynamic-batch-size
branch
from
540f5f5 to
8e330d7
Compare
fresh-borzoni
force-pushed
the
feat/dynamic-batch-size
branch
from
8e330d7 to
04f5d58
Compare
Member
Author
|
@charlesdong1991 Ty for the review, addressed, PTAL 🙏 |
charlesdong1991
approved these changes
May 9, 2026
Contributor
charlesdong1991
left a comment
charlesdong1991
left a comment
There was a problem hiding this comment.
Looks great! 👍
Can we create a follow-up issue to consider adding an integration test for this optimization?
Member
Author
|
Added an issue for integration tests: #539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #445
Adds DynamicWriteBatchSizeEstimator, mirroring Java Fluss's per-table batch size tuning. When writer.dynamic-batch-size-enabled is on, each table's target grows 10% after a batch fills past 80% and shrinks 5% below 50%, clamped to [writer.batch-size-min, writer.batch-size].
Wired into the writer's allocation path: append reads the per-table target instead of the static writer_batch_size; drain feeds the actual size back. The estimator lives on BucketAndWriteBatches behind a parking_lot::Mutex - both touch points short-circuit on the config flag, so the disabled path locks nothing.