fix: respect negative values on deserialization in REQ sketch#734
Open
proost wants to merge 3 commits into
Open
fix: respect negative values on deserialization in REQ sketch#734proost wants to merge 3 commits into
proost wants to merge 3 commits into
Conversation
leerho
reviewed
May 12, 2026
| posSeg.getFloatArray(arr, 0, count); | ||
| float minItem = Float.MAX_VALUE; | ||
| float maxItem = Float.MIN_VALUE; | ||
| float maxItem = -Float.MAX_VALUE; |
Member
There was a problem hiding this comment.
What you found here is obviously incorrect, but neither is your solution. Internally, for the Classic Quantiles, KLL and REQ, the min and max values are initialized to NaN. and the first incoming value that is not NaN, sets both the min and max values. This allows input values of +/- infinity, which your solution would not recognize. I would argue that you should use a similar solution here, for consistency if nothing else.
I would also suggest you create a test that uses +/- Infinities, just to confirm that it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Float.MIN_VALUEis smallest positive value. So if REQ sketch include negative values, min value is not respected after deserialization.C++ is ok, because it delegates to comparator not like java.
After this PR merged, I will send PR for compat in C++.