fix: median returns Float64 for integer inputs to avoid truncation#21988
Open
CuteChuanChuan wants to merge 1 commit intoapache:mainfrom
Open
fix: median returns Float64 for integer inputs to avoid truncation#21988CuteChuanChuan wants to merge 1 commit intoapache:mainfrom
median returns Float64 for integer inputs to avoid truncation#21988CuteChuanChuan wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
MEDIANover integer columns previously returned the input integer type, which truncates the.5produced when averaging the two middle values of an even-length input.For example:
What changes are included in this PR?
Are these changes tested?
Yes. Includes:
Are there any user-facing changes?
Yes — this is a breaking change for median(<integer_column>): Return type changes from the input integer type to Float64.