Skip to content

Fix CREATE FUNCTION round trip for Hive dialect#1693

Merged
alamb merged 1 commit intoapache:mainfrom
validio-io:create-function-args-test-failure
Jan 30, 2025
Merged

Fix CREATE FUNCTION round trip for Hive dialect#1693
alamb merged 1 commit intoapache:mainfrom
validio-io:create-function-args-test-failure

Conversation

@iffyio
Copy link
Copy Markdown
Contributor

@iffyio iffyio commented Jan 30, 2025

Fixes the test failure in #1690

@iffyio
Copy link
Copy Markdown
Contributor Author

iffyio commented Jan 30, 2025

My bad, I somehow managed to miss that the test was failing before merging

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iffyio -- sorry for the delay in reviewing

@alamb alamb merged commit 9c384a9 into apache:main Jan 30, 2025
@iffyio iffyio deleted the create-function-args-test-failure branch January 31, 2025 05:55
@iffyio
Copy link
Copy Markdown
Contributor Author

iffyio commented Jan 31, 2025

Thanks @alamb!

Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
Vedin added a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants