Add RETURNS TABLE() support for CREATE FUNCTION in Postgresql#1687
Merged
iffyio merged 5 commits intoapache:mainfrom Feb 3, 2025
Merged
Conversation
remysaissy
added a commit
to remysaissy/datafusion-sqlparser-rs
that referenced
this pull request
Jan 29, 2025
remysaissy
force-pushed
the
postgres/create_function_returns_table_support
branch
from
f8637f2 to
5cda5de
Compare
iffyio
reviewed
Jan 29, 2025
iffyio
approved these changes
Jan 31, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @remysaissy!
cc @alamb
Contributor
|
@remysaissy when you get the chance could you take a look to resolve the conflicts on the branch? |
Contributor
Author
|
Yes, I’ll do it today. |
…tgresql. Fixes apache#1687. # Conflicts: # tests/sqlparser_postgres.rs
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
remysaissy
force-pushed
the
postgres/create_function_returns_table_support
branch
from
5aca72c to
abecd1c
Compare
Contributor
|
Thanks @remysaissy and @iffyio |
Contributor
|
It looks like there are some real test failures |
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
…#1687) Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Vedin
pushed a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
…#1687) Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Vedin
added a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
Feb 3, 2025
…apache#1687)" This reverts commit 48bf9d0.
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
…#1687) Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CREATE FUNCTION doesn't support the RETURNS TABLE datatype (https://www.postgresql.org/docs/15/sql-createfunction.html).
This PR adds it for the PostgresSQL and Generic dialect.