Fix migration issue in UserVmManagerImpl.migrateVirtualMachineWithVolume

[GabrielBrascher]

Description

I've upgraded a stage environment from an older 4.16-SNAPSHOT to the current one and found a regression bug at the VM migration.

When calling the migrateVirtualMachineWithVolume, the following InvalidParameterValueException is launched: Unsupported hypervisor: KVM for VM migration, we support XenServer/VMware/KVM only.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

The test was executed on a cluster with KVM nodes.
At the UI, migrate a VM with a Root volume allocated in a local storage. Or, call the API command migrateVirtualMachineWithVolume.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 788

[shwstppr]

LGTM
I need to hide somewhere, added this with #5030 .
Also, have to check why this smoke tests were not showing failures

[shwstppr]

LGTM
I need to hide somewhere, added this with #5030 .
Also, have to check why this smoke tests were not showing failures

Because in test_vm_life_cycle.py,

• KVM live migration with volume is skipped on CentOS on Trillian
• for VMware test_01_migrate_VM_and_root_volume and test_02_migrate_VM_with_two_data_disks are actually offline migration tests.
• for Xenserver/XCP-ng there are no live with volume migration test

Created #5289 to add a smoke test for live migrate VM with volume for VMware.

[shwstppr]

@blueorangutan test matrix

[blueorangutan]

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[DaanHoogland]

clgtm, makes sense

[blueorangutan]

Trillian test result (tid-1533)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38298 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5288-t1533-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 85 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	Error	0.67	test_primary_storage.py
test_01_primary_storage_nfs	Error	0.12	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	Error	0.20	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	Error	1.20	test_snapshots.py
test_01_secure_vm_migration	Error	164.29	test_vm_life_cycle.py
test_02_unsecure_vm_migration	Error	276.22	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	174.97	test_vm_life_cycle.py
test_08_migrate_vm	Error	43.66	test_vm_life_cycle.py
test_hostha_kvm_host_fencing	Error	713.39	test_hostha_kvm.py
test_hostha_kvm_host_recovering	Error	733.86	test_hostha_kvm.py

[blueorangutan]

Trillian test result (tid-1532)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45341 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5288-t1532-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 86 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_primary_storage_iscsi	Error	6.45	test_primary_storage.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	Failure	38.49	test_internal_lb.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	2009.62	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	2009.67	test_host_maintenance.py

[yadvr]

Will merge this and the test fix PR and kick test matrix on the health check PR. PR LGTM

[blueorangutan]

Trillian test result (tid-1534)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 125792 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5288-t1534-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 54 look OK, 35 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestInternalLb>:setup	Error	0.00	test_internal_lb.py
ContextSuite context=TestAccounts>:setup	Error	0.00	test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup	Error	0.00	test_accounts.py
test_DeleteDomain	Error	4.17	test_accounts.py
test_forceDeleteDomain	Failure	4.06	test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup	Error	5.13	test_accounts.py
ContextSuite context=TestDomainsServiceOfferings>:setup	Error	1515.22	test_domain_service_offerings.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup	Error	0.00	test_affinity_groups_projects.py
ContextSuite context=TestAsyncJob>:setup	Error	0.00	test_async_job.py
test_01_create_iso_with_checksum_sha1	Error	66.42	test_iso.py
test_01_create_iso_with_checksum_sha1	Error	66.42	test_iso.py
test_02_create_iso_with_checksum_sha256	Error	66.42	test_iso.py
test_02_create_iso_with_checksum_sha256	Error	66.42	test_iso.py
test_03_1_create_iso_with_checksum_md5_negative	Error	66.42	test_iso.py
test_03_create_iso_with_checksum_md5	Error	66.41	test_iso.py
test_03_create_iso_with_checksum_md5	Error	66.41	test_iso.py
test_01_create_iso	Failure	1512.29	test_iso.py
ContextSuite context=TestISO>:setup	Error	3023.34	test_iso.py
ContextSuite context=TestLoadBalance>:setup	Error	0.00	test_loadbalance.py
test_3d_gpu_support	Error	1512.53	test_deploy_vgpu_enabled_vm.py
ContextSuite context=TestDeployVMFromISO>:setup	Error	0.00	test_deploy_vm_iso.py
test_list_clusters_metrics	Error	1512.00	test_metrics_api.py
test_list_vms_metrics	Error	0.16	test_metrics_api.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup	Error	0.00	test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup	Error	0.00	test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup	Error	0.00	test_diagnostics.py
ContextSuite context=TestNetworkACL>:setup	Error	0.00	test_network_acl.py
test_delete_account	Error	1511.83	test_network.py
test_delete_network_while_vm_on_it	Error	1.48	test_network.py
test_deploy_vm_l2network	Error	1.45	test_network.py
test_l2network_restart	Error	2.70	test_network.py
ContextSuite context=TestPortForwarding>:setup	Error	4.07	test_network.py
ContextSuite context=TestPublicIP>:setup	Error	2.00	test_network.py
test_reboot_router	Failure	0.04	test_network.py
test_releaseIP	Error	0.58	test_network.py
ContextSuite context=TestRouterRules>:setup	Error	0.63	test_network.py
ContextSuite context=TestAdapterTypeForNic>:setup	Error	0.00	test_nic_adapter_type.py
test_01_invalid_upgrade_kubernetes_cluster	Failure	0.00	test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster	Failure	0.00	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	0.00	test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster	Failure	0.00	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	Failure	0.00	test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster	Failure	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.00	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	Failure	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.00	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	Error	1802.55	test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup	Error	0.00	test_list_ids_parameter.py
test_nic_secondaryip_add_remove	Error	1511.76	test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup	Error	0.00	test_nested_virtualization.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	Error	0.00	test_password_server.py
ContextSuite context=TestVPCNics>:setup	Error	0.00	test_vpc_router_nics.py
ContextSuite context=TestPortForwardingRules>:setup	Error	0.00	test_portforwardingrules.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestPrivateGwACL>:setup	Error	0.00	test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup	Error	1520.57	test_projects.py
test_01_isolate_network_FW_PF_default_routes_egress_true	Failure	141.86	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	Failure	369.62	test_routers_network_ops.py
ContextSuite context=TestSnapshotRootDisk>:setup	Error	0.00	test_snapshots.py
test_01_import_storage_policies	Error	0.00	test_storage_policy.py
test_02_create_template_with_checksum_sha1	Error	65.44	test_templates.py
test_03_create_template_with_checksum_sha256	Error	65.42	test_templates.py
test_04_create_template_with_checksum_md5	Error	65.41	test_templates.py
test_05_create_template_with_no_checksum	Error	65.41	test_templates.py
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_01_volume_usage	Error	85.72	test_usage.py
ContextSuite context=TestVAppsVM>:setup	Error	1556.35	test_vm_life_cycle.py
test_10_attachAndDetach_iso	Failure	1510.61	test_vm_life_cycle.py
ContextSuite context=TestVolumes>:setup	Error	1968.81	test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup	Error	0.00	test_vpc_redundant.py