Skip to content

Do remove volume only on expunge#5213

Merged
sureshanaparti merged 1 commit into
apache:mainfrom
shapeblue:remove-volume-on-expunge
Jul 17, 2021
Merged

Do remove volume only on expunge#5213
sureshanaparti merged 1 commit into
apache:mainfrom
shapeblue:remove-volume-on-expunge

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

Description

This PR includes the changes to remove volume only on expunge.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested destroy and recover volumes.

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cltgm

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 566

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@sureshanaparti sureshanaparti added this to the 4.16.0.0 milestone Jul 16, 2021
@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-1292)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37255 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5213-t1292-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

Merging this based on approvals and test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants