ui: vmware vm import-unmanage by shwstppr · Pull Request #5075 · apache/cloudstack

shwstppr · 2021-06-04T10:14:59Z

Description

Adds UI for importing and unmanaging VMs.
A new navigation section - Tools has been added in the UI.

Doc PR: apache/cloudstack-documentation#221

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Add UI for importing and unmanaging VMs for a VMware cluster Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-06-17T10:29:35Z

@blueorangutan package

blueorangutan · 2021-06-17T10:30:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-06-17T11:02:25Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 263

yadvr

LGTM, basic checks, licenses in the new files and overall code. UI changes needs manual testing.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-06-17T13:42:16Z

@blueorangutan package

blueorangutan · 2021-06-17T13:43:02Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-06-17T14:09:05Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 265

utchoang

UI Code LGTM! Can't test in my environment.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

blueorangutan · 2021-06-18T08:25:18Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 286

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-06-23T11:34:42Z

@blueorangutan ui

shwstppr · 2021-07-05T09:41:06Z

@blueorangutan package

blueorangutan · 2021-07-05T09:42:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-07-05T10:06:41Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 472

borisstoyanov

LGTM, based on manual verification

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-07-07T06:57:02Z

Last commit unrelated to import wizard/form. A change in UI component was causing some fields not visible in AddNetworkOffering form. Fixed now.

@blueorangutan ui

blueorangutan · 2021-07-07T06:58:03Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-07T07:02:10Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5075 (SL-JID-328)

blueorangutan · 2021-07-08T08:19:18Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 498

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-07-15T08:15:59Z

@blueorangutan ui

Last commit added to use UI component added with 041948c

blueorangutan · 2021-07-15T08:17:03Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-15T08:22:00Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5075 (SL-JID-363)

andrijapanicsb · 2021-07-18T12:12:46Z

@blueorangutan ui

Last commit added to use UI component added with 041948c

This doesn't explain much what was changed (to me at least) and it comes after LGTM from Boris (and the internal review from me) @shwstppr . Also some conflicts are there. thx

blueorangutan · 2021-07-18T12:13:02Z

@andrijapanicsb a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-18T12:13:58Z

UI build: ✖️
(SL-JID-374)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-07-19T07:01:59Z

@andrijapanicsb Fixed conflicts
Commit in question b3e2ace changed the tooltip code for form items.

Before 041948c (#5133), above icon was shown with code,

<span slot="label">
  {{ $t('label.displayname') }}
  <a-tooltip :title="apiParams.displayname.description">
    <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
  </a-tooltip>
</span>

With PR #5133, new Vue component (TooltipLabel.vue) was added which allowed above code to be refactored as,

<tooltip-label slot="label" :title="$t('label.displayname')" :tooltip="apiParams.displayname.description"/>

PR #5133 was merged into main after your review.

@blueorangutan ui

blueorangutan · 2021-07-19T07:03:04Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-19T07:08:11Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5075 (SL-JID-379)

shwstppr force-pushed the vm-ingestion-ui branch from 565af62 to 4247232 Compare June 4, 2021 10:55

apache deleted a comment from blueorangutan Jun 15, 2021

ui: vmware vm import/unmanage

0ff2e96

Add UI for importing and unmanaging VMs for a VMware cluster Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr force-pushed the vm-ingestion-ui branch from 1dba6f2 to 0ff2e96 Compare June 16, 2021 12:40

shwstppr added 2 commits June 17, 2021 12:33

Merge remote-tracking branch 'apache/main' into vm-ingestion-ui

3b65627

fixes

1ef9e26

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr changed the title ~~ui: vmware vm ingestion~~ ui: vmware vm import-unmanage Jun 17, 2021

shwstppr mentioned this pull request Jun 17, 2021

vm: import/unmanage docs apache/cloudstack-documentation#221

Merged

Merge remote-tracking branch 'apache/main' into vm-ingestion-ui

60a021b

apache deleted a comment from blueorangutan Jun 17, 2021

yadvr reviewed Jun 17, 2021

View reviewed changes

yadvr added this to the 4.16.0.0 milestone Jun 17, 2021

shwstppr added 2 commits June 17, 2021 18:52

server: respect keyword param of listUnmanagedInstances API

0933689

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

add search input

90caa14

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

utchoang approved these changes Jun 18, 2021

View reviewed changes

shwstppr added 2 commits June 18, 2021 12:41

auto-select compute offering

b868fa4

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix notification name

bc1f508

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr added component:UI status:needs-testing type:enhancement labels Jun 18, 2021

naming consistency

6f9439d

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

borisstoyanov approved these changes Jul 6, 2021

View reviewed changes

fix addnetworkoffering form regression

1fdcfba

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr approved these changes Jul 15, 2021

View reviewed changes

shwstppr marked this pull request as ready for review July 15, 2021 07:43

yadvr requested a review from andrijapanicsb July 15, 2021 07:46

shwstppr marked this pull request as draft July 15, 2021 07:47

shwstppr added 3 commits July 15, 2021 13:20

Merge branch 'main' into vm-ingestion-ui

ae6d495

Merge branch 'main' into vm-ingestion-ui

c26a274

changes to use TooltipLabel component

b3e2ace

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Merge branch 'main' into vm-ingestion-ui

83bce07

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr marked this pull request as ready for review July 27, 2021 05:42

yadvr merged commit 87ee866 into apache:main Jul 27, 2021

nvazquez added type:new-feature and removed status:needs-testing labels Oct 14, 2021

Conversation

shwstppr commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

shwstppr commented Jun 17, 2021

Uh oh!

blueorangutan commented Jun 17, 2021

Uh oh!

blueorangutan commented Jun 17, 2021

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jun 17, 2021

Uh oh!

blueorangutan commented Jun 17, 2021

Uh oh!

blueorangutan commented Jun 17, 2021

Uh oh!

utchoang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 18, 2021

Uh oh!

shwstppr commented Jun 23, 2021

Uh oh!

shwstppr commented Jul 5, 2021

Uh oh!

blueorangutan commented Jul 5, 2021

Uh oh!

blueorangutan commented Jul 5, 2021

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jul 7, 2021

Uh oh!

blueorangutan commented Jul 7, 2021

Uh oh!

blueorangutan commented Jul 7, 2021

Uh oh!

blueorangutan commented Jul 8, 2021

Uh oh!

shwstppr commented Jul 15, 2021

Uh oh!

blueorangutan commented Jul 15, 2021

Uh oh!

blueorangutan commented Jul 15, 2021

Uh oh!

andrijapanicsb commented Jul 18, 2021

Uh oh!

blueorangutan commented Jul 18, 2021

Uh oh!

blueorangutan commented Jul 18, 2021

Uh oh!

shwstppr commented Jul 19, 2021

Uh oh!

blueorangutan commented Jul 19, 2021

Uh oh!

blueorangutan commented Jul 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shwstppr commented Jun 4, 2021 •

edited

Loading

utchoang left a comment •

edited

Loading