Fix repository mount failure during restore due to path format handling

[harikrishna-patnala]

Description

This PR addresses an issue mentioned here #12669

Here we are addressing the mount operation to be same as it does during backup

https://github.com/shapeblue/cloudstack/blob/b7a11cb203aeb9458460e3ce06090172b3a814d1/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtTakeBackupCommandWrapper.java#L71-L84

        List<String[]> commands = new ArrayList<>();
        commands.add(new String[]{
                libvirtComputingResource.getNasBackupPath(),
                "-o", "backup",
                "-v", vmName,
                "-t", backupRepoType,
                "-s", backupRepoAddress,
                "-m", Objects.nonNull(mountOptions) ? mountOptions : "",
                "-p", backupPath,
                "-q", command.getQuiesce() != null && command.getQuiesce() ? "true" : "false",
                "-d", diskPaths.isEmpty() ? "" : String.join(",", diskPaths)
        });

        Pair<Integer, String> result = Script.executePipedCommands(commands, libvirtComputingResource.getCmdsTimeout());

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[harikrishna-patnala]

@blueorangutan package

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (a289bb0) to head (7af5fc0).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12778   +/-   ##
=========================================
  Coverage     17.67%   17.67%           
+ Complexity    15792    15789    -3     
=========================================
  Files          5922     5922           
  Lines        533123   533136   +13     
  Branches      65201    65201           
=========================================
+ Hits          94246    94253    +7     
- Misses       428236   428238    +2     
- Partials      10641    10645    +4     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.75% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

did you mean that the issue is because executePipedCommands and runSimpleBashScriptForExitValue work differently ? @harikrishna-patnala

[harikrishna-patnala]

did you mean that the issue is because executePipedCommands and runSimpleBashScriptForExitValue work differently ? @harikrishna-patnala

Yes @weizhouapache I did not tested them separately but based on the issue reported, backup operation was successful with the repository address having back slashes (\). So I followed the same execution method in restore operation as well.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17064

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-15592)

[harikrishna-patnala]

@blueorangutan test

[blueorangutan]

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15593)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49616 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12778-t15593-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.14	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	4.90	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.77	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.77	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	28.86	test_snapshots.py
test_01_snapshot_usage	Error	23.90	test_usage.py
test_01_vpn_usage	Error	1.11	test_usage.py

[abh1sar]

Code LGTM

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[sureshanaparti]

@harikrishna-patnala can you fix the conflicts here. thanks.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17902