debian does not have libvirt-bin it has libvirt

[querplis]

cloudstack/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java

Lines 41 to 45 in 7667846

	if ("Ubuntu".equals(serverResource.getHostDistro()) || "Debian".equals(serverResource.getHostDistro())) {
	script.add("libvirt-bin");
	} else {
	script.add("libvirtd");
	}

cloudstack/debian/rules

Lines 47 to 48 in 7313a5e

	sed -i 's/Requires=libvirtd.service/Requires=libvirt-bin.service/g' packaging/systemd/$(PACKAGE)-agent.service
	sed -i 's/After=libvirtd.service/After=libvirt-bin.service/g' packaging/systemd/$(PACKAGE)-agent.service

cloudstack/debian/control

Line 25 in 7313a5e

Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless | java8-runtime | openjdk-9-jre-headless, cloudstack-common (= ${source:Version}), lsb-base (>= 9), libcommons-daemon-java, openssh-client, qemu-kvm (>= 2.5), libvirt-bin (>= 1.3), uuid-runtime, iproute2, ebtables, vlan, ipset, python-libvirt, ethtool, iptables, lsb-release, aria2

cloudstack/python/lib/cloud_utils.py

Lines 706 to 770 in 1d05fea

	class SetupLibvirt(ConfigTask):
	name = "libvirt setup"
	cfgline = "export CGROUP_DAEMON='cpu:/virt'"
	def done(self):
	try:
	if distro in (Fedora,CentOS, RHEL6): libvirtfile = "/etc/sysconfig/libvirtd"
	elif distro is Ubuntu: libvirtfile = "/etc/default/libvirt-bin"
	else: raise AssertionError, "We should not reach this"
	return self.cfgline in file(libvirtfile,"r").read(-1)
	except IOError,e:
	if e.errno is 2: raise TaskFailed("libvirt has not been properly installed on this system")
	raise
	def execute(self):
	if distro in (Fedora,CentOS, RHEL6): libvirtfile = "/etc/sysconfig/libvirtd"
	elif distro is Ubuntu: libvirtfile = "/etc/default/libvirt-bin"
	else: raise AssertionError, "We should not reach this"
	libvirtbin = file(libvirtfile,"r").read(-1)
	libvirtbin = libvirtbin + "\n" + self.cfgline + "\n"
	file(libvirtfile,"w").write(libvirtbin)
	if distro in (CentOS, Fedora, RHEL6): svc = "libvirtd"
	else: svc = "libvirt-bin"
	stop_service(svc)
	enable_service(svc)
	class SetupLiveMigration(ConfigTask):
	name = "live migration setup"
	stanzas = (
	"listen_tcp=1",
	'tcp_port="16509"',
	'auth_tcp="none"',
	"listen_tls=0",
	)
	def done(self):
	try:
	lines = [ s.strip() for s in file("/etc/libvirt/libvirtd.conf").readlines() ]
	if all( [ stanza in lines for stanza in self.stanzas ] ): return True
	except IOError,e:
	if e.errno is 2: raise TaskFailed("libvirt has not been properly installed on this system")
	raise
	def execute(self):
	for stanza in self.stanzas:
	startswith = stanza.split("=")[0] + '='
	replace_or_add_line("/etc/libvirt/libvirtd.conf",startswith,stanza)
	if distro in (Fedora, RHEL6):
	replace_or_add_line("/etc/sysconfig/libvirtd","LIBVIRTD_ARGS=","LIBVIRTD_ARGS=-l")
	elif distro is Ubuntu:
	if os.path.exists("/etc/init/libvirt-bin.conf"):
	replace_line("/etc/init/libvirt-bin.conf", "exec /usr/sbin/libvirtd","exec /usr/sbin/libvirtd -d -l")
	else:
	replace_or_add_line("/etc/default/libvirt-bin","libvirtd_opts=","libvirtd_opts='-l'")
	else:
	raise AssertionError("Unsupported distribution")
	if distro in (CentOS, Fedora, RHEL6): svc = "libvirtd"
	else: svc = "libvirt-bin"
	stop_service(svc)
	enable_service(svc)

Debian does not have libvirt-bin it has libvirtd

https://packages.debian.org/search?suite=stable&section=all&arch=any&searchon=names&keywords=libvirt

[yadvr]

@querplis officially supported KVM hosts are RHEL/CentOS and Ubuntu (http://docs.cloudstack.apache.org/en/4.11.1.0/releasenotes/compat.html#supported-hypervisor-versions). Please submit a pull request for debian.
@wido can you comment if you've ever tested on Debian+KVM?

[yadvr]

The fix is simply that only in case of Ubuntu the process name is libvirt-bin, otherwise is should be libvirtd.

[wido]

I think we can completely switch to the name libvirtd, I just tested on Ubuntu 16.04:

systemctl status libvirtd

cat /lib/systemd/system/libvirt-bin.service

[Install]
Alias=libvirtd.service

As you can see, on Ubuntu it creates an alias.

[yadvr]

I think on 14.04 it's still libvirt-bin @wido.

[wido]

We dropped Ubuntu 14.04 support in master already, so we can ignore Ubuntu 14.04 on master.

[yadvr]

Alright, in that case let's switch to libvirtd service name. /cc @sh0wstopper

[wido]

Seems good to me! Looking forward to the PR