This repository was archived by the owner on Jan 20, 2021. It is now read-only.
Add rootdisk size on compute offering#770
Merged
Merged
Conversation
GabrielBrascher
force-pushed
the
root-size-service-offering
branch
from
9750d6b to
c420fd9
Compare
GabrielBrascher
force-pushed
the
root-size-service-offering
branch
from
c420fd9 to
856adc4
Compare
Member
Author
|
@blueorangutan package |
|
@GabrielBrascher a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
GabrielBrascher
changed the title
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
davidjumani
reviewed
Sep 30, 2020
davidjumani
reviewed
Sep 30, 2020
Contributor
|
@blueorangutan package |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
davidjumani
approved these changes
Sep 30, 2020
Contributor
davidjumani
left a comment
davidjumani
left a comment
There was a problem hiding this comment.
Code LGTM. Need to test once the ACS PR has been merged
weizhouapache
pushed a commit
that referenced
this pull request
Jan 19, 2021
* Add rootdisk size oncompute offering * Change "leftover" apiParams.provisioningtype to apiParams.rootdisk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows configuring a Service Offering with root disk size.
PR Allow to configure root disk size via Service Offering (disk offering of type Service). #4341 allows enforcing VM Root disk size accordingly to its Service Offering.
NOTE: Once PR apache/cloudstack#4341 gets merged, the code of this PR will "work" with the new parameter at the API
How Has This Been Tested?
Screenshots:
Empty:
Value not supported:
Value for Root disk size supported:
