Added support for molar flow units#1196
Conversation
angularsen
left a comment
angularsen
left a comment
There was a problem hiding this comment.
Good work, tons of new stuff here.
Some comments on precision in conversions mostly, other than that this looks good.
Improve precision of test case
angularsen
left a comment
angularsen
left a comment
There was a problem hiding this comment.
Great, just a few more minor things
|
This is most likely failing because of the property marked as obsolete. I had to make a manual change after running the automatic code generation tool. The manual change was on "NumberToHeatTransferCoefficientExtensionsTest.g.cs" for a missing namespace (System.Obsolete) |
|
@angularsen please have a look, this builds perfectly fine for me |
There is no reason to annotate generated test methods with obsolete attributes. Only the types and methods related to the implementation of the unit needs it, not tests.
|
@dcasaseca I pushed a fix, reverting the manual changes to generated code and instead fixed the code generator to not emit obsolete attribute for test code. This seemed like a mistake in the existing codegen regarding obsolete units. |
|
Thank you for the effort, a lot of new stuff here! |
2 participants
No description provided.