docs(guide): add dart version of hierarchical dependency injection

[andresaraujo]

Adds Dart version of hierarchical dependency injection guide.

@kwalrath Could you take a look?

Thanks.

[kasperpeulen]

this one can be final

[andresaraujo]

Also private. Good catch +1
Edit: nope it must be public.

[zoechi]

wouldn't juts #COMMON_DIRECTIVES cover both?

[kwalrath]

@yjbanov what would you recommend?

[andresaraujo]

CORE_DIRECTIVES only include:

const List<Type> CORE_DIRECTIVES = const [
  NgClass,
  NgFor,
  NgIf,
  NgStyle,
  NgSwitch,
  NgSwitchWhen,
  NgSwitchDefault
];

[yjbanov]

I'd recommend including the minimum necessary. It does not look like you need the form directives for this example app.

[andresaraujo]

hero_editor_component.dart needs an NgModel, if I don't include FORM_DIRECTIVES It won't work.

Btw If I only include directives: const [NgModel] in that component it also does't work, only works with FORM_DIRECTIVES. Is this a bug or work as intended?

[yjbanov]

Either a bug or possibly you forgot an import?

[andresaraujo]

I think made all the corrections, I end up using: (Thanks to zoechi)

    platform_directives:
    - 'package:angular2/common.dart#COMMON_DIRECTIVES'

Do you want me to change this for a directive FORM_DIRECTIVES in the hero_editor_component.dart?

@kwalrath

[kwalrath]

@andresaraujo I think it's better to keep everything in platform_directives.

I don't know whether it's better to use COMMON_DIRECTIVES or CORE_DIRECTIVES & FORM_DIRECTIVES. @yjbanov?

[kwalrath]

This looks good to me, as far as I can tell. @sanfordredlich can you do a technical review?

[kwalrath]

@andresaraujo: You don't need to squash commits when you upload. I'll take care of that when I merge, and it'd be nice to be able to more easily see the diffs between versions.

[sanfordredlich]

LGTM. Trivial: you might want to match case on the power:

• new Hero()+ ..name = "RubberMan"+ ..power = 'flexibility',+ new Hero()+
  ..name = "Tornado"+ ..power = 'Weather changer'

On Tue, Jan 12, 2016 at 2:21 PM Kathy Walrath notifications@github.com
wrote:

@andresaraujo https://github.com/andresaraujo: You don't need to squash
commits when you upload. I'll take care of that when I merge, and it'd be
nice to be able to more easily see the diffs between versions.

—
Reply to this email directly or view it on GitHub
#683 (comment).

[yjbanov]

@kwalrath

I don't know whether it's better to use COMMON_DIRECTIVES or CORE_DIRECTIVES & FORM_DIRECTIVES. @yjbanov?

I have no preference

[kwalrath]

LGTM! I'll merge this.