[Action.config_lines] document and test behavior of commented lines#56
Merged
Merged
Conversation
arvidj
force-pushed
the
aj/comment-test-make_config_lines
branch
2 times, most recently
from
e069131 to
8189610
Compare
arvidj
force-pushed
the
aj/comment-test-make_config_lines
branch
from
8189610 to
ad4fb8f
Compare
rr0gi
approved these changes
Mar 24, 2026
raphael-proust
added a commit
that referenced
this pull request
May 12, 2026
* master: [Files.save_as]: just write directly to special files (#60) web: expose http_request_k (#58) structured logging (#59) log: add critical due to error level inflation ci: use ocaml 5.4 files: add mkdir_p (#57) [Action.config_lines] document and test behavior of commented lines (#56) update to trace 0.12 and OTEL main web: track content-type fix: avoid curl.ml crash web: track more information about request/response in span
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clarify that
Action.config_linesnot only strips lines empty lines and those that are prefixed with#, but also removes any trailing comments: the linecontent # commentis stripped tocontent.