Merged
Conversation
dhalbert
approved these changes
Apr 26, 2026
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Ha! Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This only changes the naming of a single pin on the Waveshare ESP32-S3-Matrix: When I tried did something simple like:
I would get an error like:
I eventually figured out that this pin is misnamed I01 (that is, I zero one), rather than IO1 (like input/output 1).
This PR corrects that mistake. This is the only pin on this board that appears incorrectly named like this.