Skip to content

Update package_data.py#255

Merged
TG1999 merged 5 commits intoaboutcode-org:mainfrom
thomasscheer:fixIssue240
May 6, 2026
Merged

Update package_data.py#255
TG1999 merged 5 commits intoaboutcode-org:mainfrom
thomasscheer:fixIssue240

Conversation

@thomasscheer
Copy link
Copy Markdown

Fix Issue 240
TypeError: '<' not supported between instances of 'str' and 'NoneType'

@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented Feb 3, 2026

Thanks for the PR, please run

PYINSP_REGEN_TEST_FIXTURES=yes pytest -vvs --lf

For test regen, thanks!

@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented Feb 3, 2026

@thomasscheer thanks! I will take a look on this in a few and get this merged. Thanks for the effort there 🙇

@thomasscheer
Copy link
Copy Markdown
Author

@TG1999 Could you please have a look at this opened PR.

@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented Apr 10, 2026

@thomasscheer can you please add your DCO sign off in a comment here, so we can add it in the commits. Thanks!

@thomasscheer
Copy link
Copy Markdown
Author

Signed-off-by: Thomas Scheer scheer@semvox.de

Author: Thomas Scheer scheer@semvox.de

Co-authored-by: Tushar Goel tushar.goel.dav@gmail.com

Signed-off-by: Thomas Scheer <scheer@semvox.de>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented May 6, 2026

@pombredanne https://github.com/aboutcode-org/python-inspector/pull/255/checks?check_run_id=74587898391 what does "online" tests mean here ? All other tests are passing except the "online" one, there resolution is also different from "not online", what's the difference here? Are we running the resolution's differently for them? We are getting different resolution trees for "online" and "not online" tests

TG1999 added 4 commits May 6, 2026 16:22
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Copy Markdown
Contributor

TG1999 commented May 6, 2026

CI Errors in this PR are unrelated to the code change. Merging this. Thanks @thomasscheer 🙇

@TG1999 TG1999 closed this May 6, 2026
@TG1999 TG1999 reopened this May 6, 2026
@TG1999 TG1999 merged commit acd8dda into aboutcode-org:main May 6, 2026
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants