Skip to content

fix: update testAppSpec.json to the right format#1207

Open
ttypic wants to merge 1 commit intomainfrom
fix-presence-test
Open

fix: update testAppSpec.json to the right format#1207
ttypic wants to merge 1 commit intomainfrom
fix-presence-test

Conversation

@ttypic
Copy link
Copy Markdown
Contributor

@ttypic ttypic commented May 1, 2026

Right now ably-java has copy of common's test app spec with some modifications, but the format may change we shouldn't rely on it, and use actual format instead

for now as a quick fix we update format for presence

Summary by CodeRabbit

  • Tests
    • Consolidated duplicate test data entries to improve test resource efficiency and reduce redundancy in test configurations.

@ttypic ttypic requested a review from sacOO7 May 1, 2026 11:09
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 38a8a537-f1d5-4597-8361-7b498366137a

📥 Commits

Reviewing files that changed from the base of the PR and between 5c75ea3 and 7568d59.

📒 Files selected for processing (1)
  • lib/src/test/resources/local/testAppSpec.json

Walkthrough

This change consolidates duplicate channels entries in a test data file by removing redundant channel wrappers and merging their presence objects into a single consolidated presence array, reducing file redundancy.

Changes

Cohort / File(s) Summary
Test Data Consolidation
lib/src/test/resources/local/testAppSpec.json
Removes duplicate persisted:restpresence_persisted channel entries and consolidates presence objects (client_string_0 through client_string_3) into a single unified presence array within one channel definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hops through test files with glee,
Duplicate channels? Not for me!
Consolidated with care and grace,
One presence array, its rightful place! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating testAppSpec.json to the correct format for the presence test specification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-presence-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant