Skip to content

Functions: Append caller file and line number to wp_trigger_error() log output#11430

Open
Sukhendu2002 wants to merge 3 commits intoWordPress:trunkfrom
Sukhendu2002:fix/64561-wp-trigger-error-caller-info
Open

Functions: Append caller file and line number to wp_trigger_error() log output#11430
Sukhendu2002 wants to merge 3 commits intoWordPress:trunkfrom
Sukhendu2002:fix/64561-wp-trigger-error-caller-info

Conversation

@Sukhendu2002
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/64561

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

* Generates the message when `WP_DEBUG` is true.
*
* @since 6.4.0
* @since 7.0.0 The caller's file and line number are appended to the message.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use x.x.x as it don't land in 7.0.0

continue;
}
$message .= sprintf(
' (Called from %s on line %d.)',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use escaping here

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched (int) to absint() for the line number. The file path already has esc_html(), let me know if you'd prefer a different escaping function there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants