Skip to content

I18N: Add translator context for Preview string#11408

Open
NoumaanAhamed wants to merge 1 commit intoWordPress:trunkfrom
NoumaanAhamed:fix/64986-preview-gettext-context
Open

I18N: Add translator context for Preview string#11408
NoumaanAhamed wants to merge 1 commit intoWordPress:trunkfrom
NoumaanAhamed:fix/64986-preview-gettext-context

Conversation

@NoumaanAhamed
Copy link
Copy Markdown

Summary

Fixes the ambiguous translation of the string 'Preview' used in multiple contexts. In some languages (e.g., German), different forms may be needed depending on whether 'Preview' is used as a button label, an action link, or an editor control. Without translator context, GlotPress cannot distinguish between these uses, leading to potential mistranslations.

Replaces all __( 'Preview' ) occurrences with _x( 'Preview', 'context' ) to provide explicit context for translators, consistent with the existing pattern used for other disambiguated strings in the codebase.

Changes

src/wp-includes/class-wp-editor.php — Use _x() with 'editor button' context for the TinyMCE Preview button.
src/wp-admin/includes/class-wp-theme-install-list-table.php — Use _x() with 'theme preview action' context for the theme preview link in the install themes list table.
src/wp-admin/includes/class-wp-posts-list-table.php — Use _x() with 'post preview action' context for the preview action link in the posts list table.
src/wp-admin/includes/meta-boxes.php — Use _x() with 'button' context for the preview button text in the post submit meta box.

Testing

  • Verify that the posts list table (/wp-admin/edit.php) still shows "Preview" action links correctly.
  • Verify that the themes install screen (/wp-admin/theme-install.php) still shows "Preview" links correctly.
  • Verify that the post edit screen preview button renders correctly.
  • Verify that the TinyMCE editor preview button is still accessible and functional.
  • Optionally: confirm the new context appears in GlotPress under the wp/dev project strings for 'Preview'.

Trac ticket: https://core.trac.wordpress.org/ticket/64986


Use of AI Tools

AI assistance: Yes
Tool(s): GitHub Copilot
Model(s): Claude Haiku 4.5
Used for: Identifying all affected locations and implementing the _x() replacements; changes were reviewed before submission.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mohamedahamed.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Hi @NoumaanAhamed! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant