[NFC] Deduplicate logic in Unsubtyping#8275
Merged
Merged
Conversation
They were previously printed as "(unnamed)". Instead, prefix defined type names with a $ and print basic type names as well. This makes debug logging output in various passes more informative.
Extract logic for noting subtyping, cast, and descriptor relationships from the function-parallel analysis and fixed point analysis phases of Unsubtyping into a shared CRTP utility. This will help avoid additional duplication in a follow-on PR that newly notes casts outside the function-parallel context.
kripken
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract logic for noting subtyping, cast, and descriptor relationships
from the function-parallel analysis and fixed point analysis phases of
Unsubtyping into a shared CRTP utility. This will help avoid additional
duplication in a follow-on PR that newly notes casts outside the
function-parallel context.