fix: fix submit email button on what's new page#1042
Merged
Conversation
Fern's MDX renderer strips JSX event handlers (onSubmit, onClick), so the subscribe form's validation and submission logic was never attached to the DOM. The form fell through to a native HTML POST that silently redirected back to the same page with no user feedback. Move all form logic to custom.js using plain DOM event listeners, replace inline styles with CSS classes, and add a feedback message div for success/error states. Closes PRO-2451 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌿 Preview your docs: https://vapi-preview-95be6c4a-a5f8-4f67-add3-7ed8dab23ac1.docs.buildwithfern.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/whats-new)onSubmit,onClick), so the form's validation and submission logic was never attached to the DOM. The form fell through to a native HTML POST that silently redirected back to the same page with no user feedback.custom.jsusing plain DOMaddEventListener('submit', ...), which Fern does not stripoverview.mdxwith CSS classes instyles.cssfor proper styling (including dark mode)fetch()withredirect: 'manual'andopaqueredirecttype checkMutationObserverto re-attach handler on SPA route changes (Fern uses client-side routing)data-enhancedattributeCloses PRO-2451
Testing Steps
fern docs devor navigate to preview deployment/whats-new)node fern/custom.spec.js(39 tests, 0 dependencies)