Skip to content

Internal/master#8292

Merged
rolandk-unity merged 56 commits intomasterfrom
internal/master
May 6, 2026
Merged

Internal/master#8292
rolandk-unity merged 56 commits intomasterfrom
internal/master

Conversation

@rolandk-unity
Copy link
Copy Markdown
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

guillaumelevass and others added 30 commits April 16, 2026 03:52
…eam, render-pipelines.high-definition package)
arttu-peltonen and others added 26 commits April 22, 2026 16:01
@rolandk-unity rolandk-unity requested a review from a team as a code owner May 6, 2026 15:05
@rolandk-unity rolandk-unity merged commit 3e99c0d into master May 6, 2026
1 of 2 checks passed
const string customDefineTooltip = @"The following defines will be added in the given order, after other graph defines.
Enter what comes after '#define' (e.g.: _DEBUG or MAX_STEPS 32 // your comments.)
Uncheck the checkbox to temporarily disable the define.";
const string customIncludeTooltip = @"The following hlsl files will be included in the given order, prior to other graph includes (e.g.: Custom Function Nodes).";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Custom Function Nodes includes come after ShaderGraph SubTarget filled Includes
Current Order:
- // Includes
- // Graph Includes

Question:
Does this mean they will be somewhere in between?
- // Includes
- // CustomIncludes -- NEW
- // Graph Includes

What is the point when we can already use Custom Nodes? And can we get a option to choose location?

Example:
- // CustomIncludesBeforeSubTarget --> Selectable as Dropdown in ShaderGraph Include Inspector
- // Includes --> SubTarget Includes
- // CustomIncludesAfterSubTarget --> Selectable as Dropdown in ShaderGraph Include Inspector
- // CustomIncludesBeforeGraphIncludes --> Selectable as Dropdown in ShaderGraph Include Inspector
- // GraphIncludes --> Filled from CustomNodes
- // CustomIncludesAfterGraphIncludes --> Selectable as Dropdown in ShaderGraph Include Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.