Internal/master#8292
Conversation
…the eyes resolution
…ers written in ShaderGraph
…ded for stereoscopic panoramic skyboxes
…eam, render-pipelines.high-definition package)
…eam, render-pipelines.universal package)
| const string customDefineTooltip = @"The following defines will be added in the given order, after other graph defines. | ||
| Enter what comes after '#define' (e.g.: _DEBUG or MAX_STEPS 32 // your comments.) | ||
| Uncheck the checkbox to temporarily disable the define."; | ||
| const string customIncludeTooltip = @"The following hlsl files will be included in the given order, prior to other graph includes (e.g.: Custom Function Nodes)."; |
There was a problem hiding this comment.
The Custom Function Nodes includes come after ShaderGraph SubTarget filled Includes
Current Order:
- // Includes
- // Graph Includes
Question:
Does this mean they will be somewhere in between?
- // Includes
- // CustomIncludes -- NEW
- // Graph Includes
What is the point when we can already use Custom Nodes? And can we get a option to choose location?
Example:
- // CustomIncludesBeforeSubTarget --> Selectable as Dropdown in ShaderGraph Include Inspector
- // Includes --> SubTarget Includes
- // CustomIncludesAfterSubTarget --> Selectable as Dropdown in ShaderGraph Include Inspector
- // CustomIncludesBeforeGraphIncludes --> Selectable as Dropdown in ShaderGraph Include Inspector
- // GraphIncludes --> Filled from CustomNodes
- // CustomIncludesAfterGraphIncludes --> Selectable as Dropdown in ShaderGraph Include Inspector
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.