Skip to content

Fixed non-editable link clicks opening duplicate tabs#2657

Open
matthewlipski wants to merge 3 commits intolink-optionsfrom
non-editable-link-bug-fix
Open

Fixed non-editable link clicks opening duplicate tabs#2657
matthewlipski wants to merge 3 commits intolink-optionsfrom
non-editable-link-bug-fix

Conversation

@matthewlipski
Copy link
Copy Markdown
Collaborator

@matthewlipski matthewlipski commented Apr 17, 2026

Summary

This PR fixes a bug causing the Link extension's click handler to also fire on links that were non-editable, causing duplicate tabs to open.

Closes #1040

Rationale

This is a bug.

Changes

  • Added CSS class and data-inline-content-type attribute to inline/rich-text links to differentiate them from links that may be rendered by e.g. custom blocks.
  • Made click handler in Link extension ignore links without those.

Impact

N/A

Testing

N/A, Needed?

Screenshots/Video

N/A

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added.
  • All existing tests pass.
  • The documentation has been updated to reflect the new feature

Additional Notes

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blocknote Ready Ready Preview Apr 17, 2026 5:42pm
blocknote-website Ready Ready Preview Apr 17, 2026 5:42pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b17b72b0-d298-4e46-aab4-edf045589356

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch non-editable-link-bug-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant