Fixed non-editable link clicks opening duplicate tabs#2657
Fixed non-editable link clicks opening duplicate tabs#2657matthewlipski wants to merge 3 commits intolink-optionsfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR fixes a bug causing the
Linkextension's click handler to also fire on links that were non-editable, causing duplicate tabs to open.Closes #1040
Rationale
This is a bug.
Changes
data-inline-content-typeattribute to inline/rich-text links to differentiate them from links that may be rendered by e.g. custom blocks.Linkextension ignore links without those.Impact
N/A
Testing
N/A, Needed?
Screenshots/Video
N/A
Checklist
Additional Notes