Skip to content

Add h index#8036

Merged
chriso345 merged 4 commits intoTheAlgorithms:masterfrom
alexpantyukhin:add_h_index
May 17, 2023
Merged

Add h index#8036
chriso345 merged 4 commits intoTheAlgorithms:masterfrom
alexpantyukhin:add_h_index

Conversation

@alexpantyukhin
Copy link
Copy Markdown
Member

@alexpantyukhin alexpantyukhin commented Dec 19, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 19, 2022
a-r-r-o-w
a-r-r-o-w approved these changes Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

realstealthninja
realstealthninja approved these changes Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CaedenPH
CaedenPH requested changes Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, but other than that looks good!

Comment thread other/h_index.py Outdated
@alexpantyukhin @CaedenPH
Update other/h_index.py
0b26c41 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
CaedenPH
CaedenPH approved these changes Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexpantyukhin
Copy link
Copy Markdown
Member Author

alexpantyukhin commented Apr 14, 2023

Hello, what about this PR?

@chriso345 chriso345 merged commit 61cfb43 into TheAlgorithms:master May 17, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label May 17, 2023
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@alexpantyukhin @tianyizheng02
Add h index (TheAlgorithms#8036)
d766d57
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

@chriso345 chriso345 chriso345 approved these changes

+2 more reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexpantyukhin @CaedenPH @chriso345 @realstealthninja @a-r-r-o-w