Skip to content

TD-7343 Needs to add error msg on Add proficiencies to assessment'scr…#3593

Merged
rshrirohit merged 1 commit into
DLS-Release-v1.3.1from
Develop/Fixes/TD-7343-NeedstoadderrormsgonAddproficienciestoassessmentscreenwhensavingthepagewithoutselectingtheproficiencies
May 29, 2026
Merged

TD-7343 Needs to add error msg on Add proficiencies to assessment'scr…#3593
rshrirohit merged 1 commit into
DLS-Release-v1.3.1from
Develop/Fixes/TD-7343-NeedstoadderrormsgonAddproficienciestoassessmentscreenwhensavingthepagewithoutselectingtheproficiencies

Conversation

@sherif-olaboye
Copy link
Copy Markdown
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-7343

Description

Add an error state to the page to notify the user when no competency is selected and the “Add Selected Competency” button is clicked.

Screenshots

image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

…een when saving the page without selecting the proficiencies
@rshrirohit rshrirohit merged commit d511924 into DLS-Release-v1.3.1 May 29, 2026
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-7343-NeedstoadderrormsgonAddproficienciestoassessmentscreenwhensavingthepagewithoutselectingtheproficiencies branch May 29, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants