Adds newline and wrap buttons to code view#351
Adds newline and wrap buttons to code view#351enykeev merged 7 commits intoStackStorm:masterfrom Mastercard:feature/action_output_new_lines
Conversation
|
Looks useful indeed 👍 cc @enykeev |
There was a problem hiding this comment.
Thanks for the contribution!
The only thing I would ask you is to try and style buttons to match an overall style. You can check http://fontello.com/ to see if there's an icon that suites this actions. You can see what fonts and glyphs we already using by importing fontello.json there.
| scope.$watch('code', function (code) { | ||
|
|
||
| scope.hidden = true; | ||
| scope.wrap = false; |
There was a problem hiding this comment.
Please make sure you use spaces and not tabs for indentation. Not sure why linter didn't point you to that, will check.
|
Hi @leleSahil, Is it feasible for you to include in this PR an enhancement to make the horizontal scroll bar much more prominent? Note that in the following example where Chrome is being used, the scroll bar is very hard to pick out. It's just to the left of the middle in this example.
|
|
Hi @enykeev, I can't seem to find any good icons on fontello. Is it absolutely necessary to use an icon from there? Or to use an icon at all? |
|
No, not really necessary, icons just help something to look actionable without using default button appearance. Just style them to look like other buttons in st2web, that should be enough. |
|
Hi @enykeev, I've changed the styling to match the other buttons in st2web and removed the tabs. Do you mind reviewing? We were hoping to get this included in your next release! |
|
Thanks! I'll give it a look first thing tomorrow morning. |
This will help fit more code in the vertical space we have and reduce the ammount of attention this buttons drag.
|
Here is few additions from me. @leleSahil please take a look and tell me if it works for you. |
|
These look good to me! I'm sorry for the late response, I didn't see that you had responded with additional changes. Is it still possible to get this into the most recent release? |
|
Yeah, this will be the part of 2.3. |
5 participants
Addresses #329
Allows long lines code view to be wrapped in the window and/or new lines to be rendered to aid in reading output
Before
After
