Updates to custom YAQL and Jinja filters#552
Merged
Conversation
Signed-off-by: Matt Oswalt <oswaltm@brocade.com>
Mierdin
changed the title
Mierdin
changed the title
added 3 commits
July 15, 2017 14:19
Signed-off-by: Matt Oswalt <oswaltm@brocade.com>
…eprecation Signed-off-by: Matt Oswalt <oswaltm@brocade.com>
Signed-off-by: Matt Oswalt <oswaltm@brocade.com>
arm4b
reviewed
Jul 16, 2017
docs/source/upgrade_notes.rst
Outdated
|
|
||
| * The ``st2kv`` function has been changed (in 2.3.2) so that it no longer attempts to decrypt stored values by | ||
| default. To return decrypted values, this must be explictly enabled via parameter, like so: | ||
| ``st2kv('st2_key_id', decrypt=true)``. |
Member
There was a problem hiding this comment.
@Mierdin Yeah, this looks like a breaking change indeed. 👍 for the upgrade note.
I also think it's better to include it in major release like 2.4.0, instead of 2.3.2 patch release.
Let's be consistent, from the patch release users expect bug fixes, not changing the important core behavior and existing workflows they rely on.
WDYT?
Member
Author
There was a problem hiding this comment.
I personally don't mind either way. Only reason I was aiming for 2.3.2 is because @lakshmi-kannan recommended it. I'll let him chime in on the matter; there's no question that this is a breaking change.
added 2 commits
July 26, 2017 22:44
Signed-off-by: Matt Oswalt <oswaltm@brocade.com>
Mierdin
changed the title
Member
Author
|
@armab @lakshmi-kannan FYI I removed references to 2.3.2, updated to 2.4 |
LindsayHill
approved these changes
Jul 27, 2017
added 2 commits
July 27, 2017 22:36
Signed-off-by: Matt Oswalt <oswaltm@brocade.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers changes in StackStorm/st2mistral#30
st2kvthat adds a parameter to explicitly enable decryption in st2kv (disabled by default now).