Skip to content

Add Netbox automation#32

Merged
scoopex merged 45 commits into
mainfrom
netbox
Nov 25, 2024
Merged

Add Netbox automation#32
scoopex merged 45 commits into
mainfrom
netbox

Conversation

@matofeder
Copy link
Copy Markdown
Member

@matofeder matofeder commented Jul 30, 2024 •
edited
Loading

@matofeder matofeder marked this pull request as draft July 30, 2024 06:46
@matofeder matofeder force-pushed the netbox branch 4 times, most recently from a745752 to 03520a4 Compare August 5, 2024 11:32
@matofeder matofeder force-pushed the netbox branch 13 times, most recently from c0bb68e to d61431f Compare August 14, 2024 13:07
@matofeder matofeder force-pushed the netbox branch 8 times, most recently from 3d37aca to 4045b3d Compare August 20, 2024 07:59
@matofeder matofeder mentioned this pull request Aug 21, 2024
Closed
9 tasks
@matofeder matofeder force-pushed the netbox branch 3 times, most recently from 163f7bc to 74a2ca8 Compare August 22, 2024 13:34
matofeder and others added 23 commits November 18, 2024 14:30
@matofeder
Update ZTP provisionig script
dcffe20 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Fix interfaces unnumbered in template
820c89f 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Update bootstrap docs
8c0c941 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Add netbox plugins and related configuration
3989223 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Update sonic config diff script to the integrated SONiC config
5caeb13 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Fix config diff script for sonic
b0e11e2 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Update netbox docs
76f4ee2 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Fix compare the sonic config diff Netbox script
bcb674d 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Fix template sonic
22e4cad 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Fix diff script for sonic config
2d663a5 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Add sync config script
f8db27f 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Add Netbox provisioning docs
096740d 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
update network configs
2a904aa 
Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
add a extra replacement
03dac7f 
Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
unified server configs
f3a1f78 
Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Update LAB switches configuration
1727306 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
Refactor generator (#71)
26f2679 
* refactor group lookup
* add documentation
* add timeout and connections close

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
fix security groups problem and add script execution
cb0f89f 
- fix security groups problem
- add script execution

Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder @scoopex
Fix switch CTL backup for frr part of config (#70)
f50e753 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Co-authored-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
Enhance Stresstest (#73)
137e30a 
* enhance quotas

Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
Dump ansible inventory (#74)
8bd9f70 
Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Fix review comment
90dabff 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex @matofeder
add a index at the main Readme.md
12d6985 
Signed-off-by: Marc Schöchlin <schoechlin@osb-alliance.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
github-advanced-security[bot]
github-advanced-security AI found potential problems Nov 18, 2024
View reviewed changes
Comment thread misc/manage/lib/landscape.py
self.assign_role_to_user("manager")
LOGGER.info(
f"Created user {self.obj.name} / {self.obj.id} with password {self.obj.password} in {self.domain.name}")
f"Created user {self.obj.name} / {self.obj.id} with password {self.obj.password} in {domain_ident(self.domain.id)}")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text.

Copilot Autofix

AI over 1 year ago

To fix the problem, we need to remove the logging of sensitive information, specifically the user password. Instead of logging the password, we can log a message that indicates the user was created without including the sensitive details. This change should be made in the create_and_get_user method of the SCSLandscapeTestUser class.

We will replace the line that logs the password with a line that logs a message indicating the user was created, without including the password. This change will ensure that sensitive information is not exposed in the logs.

Suggested changeset 1
misc/manage/lib/landscape.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/misc/manage/lib/landscape.py b/misc/manage/lib/landscape.py
--- a/misc/manage/lib/landscape.py
+++ b/misc/manage/lib/landscape.py
@@ -95,3 +95,3 @@
         LOGGER.info(
-            f"Created user {self.obj.name} / {self.obj.id} with password {self.obj.password} in {domain_ident(self.domain.id)}")
+            f"Created user {self.obj.name} / {self.obj.id} in {domain_ident(self.domain.id)}")
         return self.obj
EOF
@@ -95,3 +95,3 @@
LOGGER.info(
f"Created user {self.obj.name} / {self.obj.id} with password {self.obj.password} in {domain_ident(self.domain.id)}")
f"Created user {self.obj.name} / {self.obj.id} in {domain_ident(self.domain.id)}")
return self.obj
Copilot is powered by AI and may make mistakes. Always verify output.
matofeder and others added 4 commits November 18, 2024 14:31
@matofeder
Merge branch 'main' into netbox
e7ae077
@matofeder
Update tinyproxy allowd networks and document it
c4ab497 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
Encrypt netbox_config_diff credentials
8437436 
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@scoopex
Merge branch 'main' into netbox
6520196
@scoopex scoopex mentioned this pull request Nov 25, 2024
Open
@scoopex
Copy link
Copy Markdown
Contributor

scoopex commented Nov 25, 2024

To ensure that this documentation can be found or that this MVP can be continued at a later date, it would be good to link this documentation on the documentation page.

In @maxwolfs 's and my opinion, we add a ‘Concepts’ section below https://docs.scs.community/contributor-docs where we add this documentation as a menu item ‘Netbox SONiC Provisioning’.

See: SovereignCloudStack/docs#274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scoopex scoopex scoopex left review comments

@OgarOgarovic OgarOgarovic OgarOgarovic approved these changes

@MatusJenca2 MatusJenca2 Awaiting requested review from MatusJenca2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automate deployment and management of SONiC switches in utilizing Netbox as source of truth

4 participants

@matofeder @scoopex @OgarOgarovic @github-advanced-security